Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: port Analysis.BoundedVariation #4824

Closed
wants to merge 9 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Jun 7, 2023

This PR also corrects a mis-forward-port of leanprover-community/mathlib3#18080


Open in Gitpod

@urkud urkud added the mathlib-port This is a port of a theory file from mathlib. label Jun 7, 2023
urkud added 3 commits June 8, 2023 15:59
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@urkud urkud force-pushed the port/Analysis.BoundedVariation branch from cdda79a to aa2a0b2 Compare June 8, 2023 21:02
@urkud urkud force-pushed the port/Analysis.BoundedVariation branch from aa2a0b2 to 45af95f Compare June 8, 2023 23:19
@Ruben-VandeVelde
Copy link
Collaborator

@urkud still working on this?

@urkud
Copy link
Member Author

urkud commented Jun 12, 2023

Yes

@urkud
Copy link
Member Author

urkud commented Jun 12, 2023

I'll fix whatever i can today.

@Ruben-VandeVelde Ruben-VandeVelde added the WIP Work in progress label Jun 12, 2023
@urkud urkud added the help-wanted The author needs attention to resolve issues label Jun 19, 2023
@j-loreaux
Copy link
Collaborator

I'm currently working on this.

@j-loreaux j-loreaux added awaiting-review and removed help-wanted The author needs attention to resolve issues WIP Work in progress labels Jun 19, 2023
@jcommelin
Copy link
Member

@j-loreaux for some reason github doesn't want to show me the diff between mathport output and the HEAD of the PR branch. Did you maybe push in a funny way?

@kim-em
Copy link
Contributor

kim-em commented Jun 20, 2023

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Jun 20, 2023
bors bot pushed a commit that referenced this pull request Jun 20, 2023
This PR also corrects a mis-forward-port of leanprover-community/mathlib3#18080



Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
@bors
Copy link

bors bot commented Jun 20, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port Analysis.BoundedVariation [Merged by Bors] - feat: port Analysis.BoundedVariation Jun 20, 2023
@bors bors bot closed this Jun 20, 2023
@bors bors bot deleted the port/Analysis.BoundedVariation branch June 20, 2023 12:35
alexkeizer pushed a commit that referenced this pull request Jun 22, 2023
This PR also corrects a mis-forward-port of leanprover-community/mathlib3#18080



Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
kim-em pushed a commit that referenced this pull request Jun 23, 2023
This PR also corrects a mis-forward-port of leanprover-community/mathlib3#18080



Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
kim-em pushed a commit that referenced this pull request Jun 23, 2023
This PR also corrects a mis-forward-port of leanprover-community/mathlib3#18080



Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
kim-em pushed a commit that referenced this pull request Jun 25, 2023
This PR also corrects a mis-forward-port of leanprover-community/mathlib3#18080



Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants