Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore: add links to porting notes #5111

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - chore: add links to porting notes #5111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc65cdf
chore: add links to porting notes
Jun 16, 2023
e8d4d57
merge
Jun 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Mathlib/AlgebraicGeometry/Spec.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,6 +346,7 @@ theorem Spec_map_localization_isIso (R : CommRingCat) (M : Submonoid R)
(Spec.toPresheafedSpace.map (CommRingCat.ofHom (algebraMap R (Localization M))).op) x) := by
erw [← localRingHom_comp_stalkIso]
-- Porting note: replaced `apply (config := { instances := false })`.
-- See https://github.com/leanprover/lean4/issues/2273
refine @IsIso.comp_isIso _ _ _ _ _ _ _ _ (?_)
refine @IsIso.comp_isIso _ _ _ _ _ _ _ (?_) _
/- I do not know why this is defeq to the goal, but I'm happy to accept that it is. -/
Expand Down
3 changes: 2 additions & 1 deletion Mathlib/Topology/Sheaves/Operations.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,8 @@ noncomputable def toTotalQuotientPresheaf : F ⟶ F.totalQuotientPresheaf :=
instance : Epi (toTotalQuotientPresheaf F) := epi_toLocalizationPresheaf _

instance (F : X.Sheaf CommRingCat.{w}) : Mono F.presheaf.toTotalQuotientPresheaf := by
-- Porting note : was an `apply (config := { synthAssignedInstances := false })`
-- Porting note : was an `apply (config := { instances := false })`
-- See https://github.com/leanprover/lean4/issues/2273
suffices : ∀ (U : (Opens ↑X)ᵒᵖ), Mono (F.presheaf.toTotalQuotientPresheaf.app U)
. apply NatTrans.mono_of_mono_app
intro U
Expand Down