-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat: define NonUnitalSubring
s
#5151
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
bors d+
✌️ j-loreaux can now approve this pull request. To approve and merge a pull request, simply reply with |
bors merge |
This continues the non-unital-ization of mathlib by defining `NonUnitalSubring`. We attempt to provide as much feature parity as possible with both `NonUnitalSubsemiring` and `Subring`.
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
NonUnitalSubring
sNonUnitalSubring
s
This continues the non-unital-ization of mathlib. - [x] depends on: #5151
This continues the non-unital-ization of mathlib by defining `NonUnitalSubring`. We attempt to provide as much feature parity as possible with both `NonUnitalSubsemiring` and `Subring`.
This continues the non-unital-ization of mathlib. - [x] depends on: #5151
This continues the non-unital-ization of mathlib This PR also redefines `StarSubalgebra.centralizer` so that it no longer requires the set `s` provided to be closed under `star`, and instead the carrier is just the `Set.centralizer (s ∪ star s)`. Consequently, this changes some things in von Neumann algebras, where we now need to see that `Set.centralizer (↑S ∪ star ↑S) = Set.centralizer ↑S`, where `S` is a `StarSubalgebra`. Therefore we add the `simp` lemma `StarMemClass.star_coe_eq`. - [x] depends on: #5151 - [x] depends on: #5512
… `Algebra.adjoin` (#5602) If `S` is non-unital subalgebra of a unital `R`-algebra `A`, there is a natural surjective map `Unitization R S →ₐ[R] Algebra.adjoin R (S : Set A)`. When `1 ∉ S` and `R` is a field, this becomes and `AlgEquiv`. We specialize this to the `ℕ`-unitization of a non-unital subsemiring and its `Subsemiring.closure`, as well as the `ℤ`-unitization of a non-unital subring and its `Subring.closure`. We also extend the above map to a `StarAlgHom` in the case of `NonUnitalStarSubalgebra`s. This continues the non-unital-ization of mathlib. - [x] depends on: #5151 - [x] depends on: #5512 - [x] depends on: #5537
This continues the non-unital-ization of mathlib by defining `NonUnitalSubring`. We attempt to provide as much feature parity as possible with both `NonUnitalSubsemiring` and `Subring`.
This continues the non-unital-ization of mathlib. - [x] depends on: #5151
This continues the non-unital-ization of mathlib This PR also redefines `StarSubalgebra.centralizer` so that it no longer requires the set `s` provided to be closed under `star`, and instead the carrier is just the `Set.centralizer (s ∪ star s)`. Consequently, this changes some things in von Neumann algebras, where we now need to see that `Set.centralizer (↑S ∪ star ↑S) = Set.centralizer ↑S`, where `S` is a `StarSubalgebra`. Therefore we add the `simp` lemma `StarMemClass.star_coe_eq`. - [x] depends on: #5151 - [x] depends on: #5512
… `Algebra.adjoin` (#5602) If `S` is non-unital subalgebra of a unital `R`-algebra `A`, there is a natural surjective map `Unitization R S →ₐ[R] Algebra.adjoin R (S : Set A)`. When `1 ∉ S` and `R` is a field, this becomes and `AlgEquiv`. We specialize this to the `ℕ`-unitization of a non-unital subsemiring and its `Subsemiring.closure`, as well as the `ℤ`-unitization of a non-unital subring and its `Subring.closure`. We also extend the above map to a `StarAlgHom` in the case of `NonUnitalStarSubalgebra`s. This continues the non-unital-ization of mathlib. - [x] depends on: #5151 - [x] depends on: #5512 - [x] depends on: #5537
This continues the non-unital-ization of mathlib by defining
NonUnitalSubring
. We attempt to provide as much feature parity as possible with bothNonUnitalSubsemiring
andSubring
.There are a small number of changes to existing declarations, but I don't expect these need to be backported.
Set.neg_mem_center
just has its type class assumptions generalized and theNonUnitalSubsemiring.Basic
file is a leaf prior to this PR.