Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: define NonUnitalSubalgebra and develop basic API #5512

Closed
wants to merge 21 commits into from

Conversation

j-loreaux
Copy link
Collaborator

@j-loreaux j-loreaux commented Jun 27, 2023

This continues the non-unital-ization of mathlib.


Open in Gitpod

@j-loreaux j-loreaux added awaiting-review The author would like community review of the PR awaiting-CI after-port new-feature Add features not present in Mathlib 3 labels Jun 27, 2023
@semorrison semorrison added the blocked-by-other-PR This PR depends on another PR which is still in the queue. label Jun 27, 2023
@j-loreaux j-loreaux added WIP Work in progress and removed awaiting-review The author would like community review of the PR labels Jun 28, 2023
@j-loreaux j-loreaux added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Jun 28, 2023
@semorrison semorrison removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. label Jul 1, 2023
@semorrison
Copy link
Contributor

This PR/issue depends on:

@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Jul 1, 2023
@j-loreaux j-loreaux removed merge-conflict The PR has a merge conflict with master, and needs manual merging. after-port labels Jul 1, 2023
Copy link
Contributor

@ocfnash ocfnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small suggestions.

bors d+

Mathlib/LinearAlgebra/Span.lean Outdated Show resolved Hide resolved
Mathlib/Algebra/Algebra/NonUnitalSubalgebra.lean Outdated Show resolved Hide resolved
Mathlib/Algebra/Algebra/NonUnitalSubalgebra.lean Outdated Show resolved Hide resolved
Mathlib/Algebra/Algebra/NonUnitalSubalgebra.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Jul 2, 2023

✌️ j-loreaux can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@semorrison semorrison added delegated and removed awaiting-review The author would like community review of the PR labels Jul 2, 2023
@j-loreaux
Copy link
Collaborator Author

bors merge

bors bot pushed a commit that referenced this pull request Jul 3, 2023
This continues the non-unital-ization of mathlib.

- [x] depends on: #5151
@bors
Copy link

bors bot commented Jul 3, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: define NonUnitalSubalgebra and develop basic API [Merged by Bors] - feat: define NonUnitalSubalgebra and develop basic API Jul 3, 2023
@bors bors bot closed this Jul 3, 2023
@bors bors bot deleted the j-loreaux/NonUnitalSubalgebra branch July 3, 2023 01:50
kbuzzard pushed a commit that referenced this pull request Jul 6, 2023
This continues the non-unital-ization of mathlib.

- [x] depends on: #5151
bors bot pushed a commit that referenced this pull request Jul 18, 2023
This continues the non-unital-ization of mathlib

This PR also redefines `StarSubalgebra.centralizer` so that it no longer requires the set `s` provided to be closed under `star`, and instead the carrier is just the `Set.centralizer (s ∪ star s)`. Consequently, this changes some things in von Neumann algebras, where we now need to see that `Set.centralizer (↑S ∪ star ↑S) = Set.centralizer ↑S`, where `S` is a `StarSubalgebra`. Therefore we add the `simp` lemma `StarMemClass.star_coe_eq`.

- [x] depends on: #5151 
- [x] depends on: #5512
bors bot pushed a commit that referenced this pull request Aug 4, 2023
… `Algebra.adjoin` (#5602)

If `S` is non-unital subalgebra of a unital `R`-algebra `A`, there is a natural surjective map `Unitization R S →ₐ[R] Algebra.adjoin R (S : Set A)`. When `1 ∉ S` and `R` is a field, this becomes and `AlgEquiv`.

We specialize this to the `ℕ`-unitization of a non-unital subsemiring and its `Subsemiring.closure`, as well as the `ℤ`-unitization of a non-unital subring and its `Subring.closure`. We also extend the above map to a `StarAlgHom` in the case of `NonUnitalStarSubalgebra`s.

This continues the non-unital-ization of mathlib.

- [x] depends on: #5151
- [x] depends on: #5512 
- [x] depends on: #5537
semorrison pushed a commit that referenced this pull request Aug 14, 2023
This continues the non-unital-ization of mathlib.

- [x] depends on: #5151
semorrison pushed a commit that referenced this pull request Aug 14, 2023
This continues the non-unital-ization of mathlib

This PR also redefines `StarSubalgebra.centralizer` so that it no longer requires the set `s` provided to be closed under `star`, and instead the carrier is just the `Set.centralizer (s ∪ star s)`. Consequently, this changes some things in von Neumann algebras, where we now need to see that `Set.centralizer (↑S ∪ star ↑S) = Set.centralizer ↑S`, where `S` is a `StarSubalgebra`. Therefore we add the `simp` lemma `StarMemClass.star_coe_eq`.

- [x] depends on: #5151 
- [x] depends on: #5512
semorrison pushed a commit that referenced this pull request Aug 14, 2023
… `Algebra.adjoin` (#5602)

If `S` is non-unital subalgebra of a unital `R`-algebra `A`, there is a natural surjective map `Unitization R S →ₐ[R] Algebra.adjoin R (S : Set A)`. When `1 ∉ S` and `R` is a field, this becomes and `AlgEquiv`.

We specialize this to the `ℕ`-unitization of a non-unital subsemiring and its `Subsemiring.closure`, as well as the `ℤ`-unitization of a non-unital subring and its `Subring.closure`. We also extend the above map to a `StarAlgHom` in the case of `NonUnitalStarSubalgebra`s.

This continues the non-unital-ization of mathlib.

- [x] depends on: #5151
- [x] depends on: #5512 
- [x] depends on: #5537
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated new-feature Add features not present in Mathlib 3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants