[Merged by Bors] - feat: define NonUnitalStarSubalgebras and develop basic API
#5537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-loreaux
added
WIP
3 tasks
semorrison
added
merge-conflict
|
This PR/issue depends on: |
semorrison
removed
the
merge-conflict
j-loreaux
added
awaiting-review
|
@semorrison I requested your review primarily because of the change mentioned in the PR description to |
ocfnash
approved these changes
Jul 18, 2023
|
✌️ j-loreaux can now approve this pull request. To approve and merge a pull request, simply reply with |
leanprover-community-mathlib4-bot
added
delegated
and removed
awaiting-review
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Jul 18, 2023
This continues the non-unital-ization of mathlib This PR also redefines `StarSubalgebra.centralizer` so that it no longer requires the set `s` provided to be closed under `star`, and instead the carrier is just the `Set.centralizer (s ∪ star s)`. Consequently, this changes some things in von Neumann algebras, where we now need to see that `Set.centralizer (↑S ∪ star ↑S) = Set.centralizer ↑S`, where `S` is a `StarSubalgebra`. Therefore we add the `simp` lemma `StarMemClass.star_coe_eq`. - [x] depends on: #5151 - [x] depends on: #5512
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
NonUnitalStarSubalgebras and develop basic APINonUnitalStarSubalgebras and develop basic API
bors bot
pushed a commit
that referenced
this pull request
Aug 4, 2023
… `Algebra.adjoin` (#5602) If `S` is non-unital subalgebra of a unital `R`-algebra `A`, there is a natural surjective map `Unitization R S →ₐ[R] Algebra.adjoin R (S : Set A)`. When `1 ∉ S` and `R` is a field, this becomes and `AlgEquiv`. We specialize this to the `ℕ`-unitization of a non-unital subsemiring and its `Subsemiring.closure`, as well as the `ℤ`-unitization of a non-unital subring and its `Subring.closure`. We also extend the above map to a `StarAlgHom` in the case of `NonUnitalStarSubalgebra`s. This continues the non-unital-ization of mathlib. - [x] depends on: #5151 - [x] depends on: #5512 - [x] depends on: #5537
semorrison
pushed a commit
that referenced
this pull request
Aug 14, 2023
This continues the non-unital-ization of mathlib This PR also redefines `StarSubalgebra.centralizer` so that it no longer requires the set `s` provided to be closed under `star`, and instead the carrier is just the `Set.centralizer (s ∪ star s)`. Consequently, this changes some things in von Neumann algebras, where we now need to see that `Set.centralizer (↑S ∪ star ↑S) = Set.centralizer ↑S`, where `S` is a `StarSubalgebra`. Therefore we add the `simp` lemma `StarMemClass.star_coe_eq`. - [x] depends on: #5151 - [x] depends on: #5512
semorrison
pushed a commit
that referenced
this pull request
Aug 14, 2023
… `Algebra.adjoin` (#5602) If `S` is non-unital subalgebra of a unital `R`-algebra `A`, there is a natural surjective map `Unitization R S →ₐ[R] Algebra.adjoin R (S : Set A)`. When `1 ∉ S` and `R` is a field, this becomes and `AlgEquiv`. We specialize this to the `ℕ`-unitization of a non-unital subsemiring and its `Subsemiring.closure`, as well as the `ℤ`-unitization of a non-unital subring and its `Subring.closure`. We also extend the above map to a `StarAlgHom` in the case of `NonUnitalStarSubalgebra`s. This continues the non-unital-ization of mathlib. - [x] depends on: #5151 - [x] depends on: #5512 - [x] depends on: #5537
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This continues the non-unital-ization of mathlib
This PR also redefines
StarSubalgebra.centralizerso that it no longer requires the setsprovided to be closed understar, and instead the carrier is just theSet.centralizer (s ∪ star s). Consequently, this changes some things in von Neumann algebras, where we now need to see thatSet.centralizer (↑S ∪ star ↑S) = Set.centralizer ↑S, whereSis aStarSubalgebra. Therefore we add thesimplemmaStarMemClass.star_coe_eq.NonUnitalSubrings #5151NonUnitalSubalgebraand develop basic API #5512I've removed the
after-portlabel because I think the changes to existing API are minimal enough (and used in very few places) to warrant consideration.