-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: the monoidal structure on graded objects #6379
Conversation
Hi @semorrison, this PR is currently quite a daunting task to review. Would you mind splitting it up into smaller PRs? I'm happy to review the categorical parts of the PR, but I feel that I'm not the best person to review the changes to the three low-level files, so I would prefer if these were in a different PR (which would also be more visible to the right reviewers). |
Sorry, I don't anticipate having much time to doing substantial new work here, e.g. splitting up the PR. Hopefully someone might want to adopt it, or at least it can be inspiration that this is possible when someone needs it. |
I think I will adopt this PR, and refactor it so as to allow further useful generalizations. The idea would be to "extend" a bifunctor In case the functor |
@joelriou, great to hear, I look forward to seeing what you come up with. Please feel free to close this PR either immediately or later. |
Joint work with @joelriou.