Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: the monoidal structure on graded objects #6379

Closed
wants to merge 93 commits into from

Conversation

kim-em
Copy link
Contributor

@kim-em kim-em commented Aug 5, 2023

Joint work with @joelriou.


Open in Gitpod

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Aug 10, 2023
@kim-em kim-em requested review from TwoFX and joelriou August 10, 2023 23:45
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) and removed merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) labels Aug 11, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Aug 15, 2023
@TwoFX
Copy link
Member

TwoFX commented Aug 26, 2023

Hi @semorrison, this PR is currently quite a daunting task to review. Would you mind splitting it up into smaller PRs? I'm happy to review the categorical parts of the PR, but I feel that I'm not the best person to review the changes to the three low-level files, so I would prefer if these were in a different PR (which would also be more visible to the right reviewers).

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Aug 26, 2023
@kim-em kim-em added the please-adopt Inactive PR (would be valuable to adopt) label Aug 27, 2023
@kim-em
Copy link
Contributor Author

kim-em commented Aug 27, 2023

Sorry, I don't anticipate having much time to doing substantial new work here, e.g. splitting up the PR. Hopefully someone might want to adopt it, or at least it can be inspiration that this is possible when someone needs it.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Aug 29, 2023
@bors bors bot changed the base branch from master to ScottCarnahan/BinomialRing2 September 17, 2023 03:25
@kim-em kim-em changed the base branch from ScottCarnahan/BinomialRing2 to master September 17, 2023 12:13
@joelriou
Copy link
Collaborator

joelriou commented Sep 22, 2023

I think I will adopt this PR, and refactor it so as to allow further useful generalizations. The idea would be to "extend" a bifunctor F : C₁ ⥤ C₂ ⥤ C₃ to a functor GradedObject I C₁ ⥤ GradedObject J C₂ ⥤ GradedObject (I × J) C₃ and to introduce a kind of "integration" for GradedObject. This would be a functor GradedObject.map C φ : GradedObject I C ⥤ GradedObject I' C attached to a map φ : I → I' which would use some coproducts in C. In case I is a monoid and φ is the addition, we shall get a functor GradedObject (I × I) C₃ ⥤ GradedObject I C₃, and using this, we could "extend" F to a functor GradedObject I C₁ ⥤ GradedObject I C₂ ⥤ GradedObject I C₃.

In case the functor F is the tensor product for a monoidal category C, this will give a candidate tensor functor for a monoidal category structure on GradedObject I C. Then, developing a suitable API for these constructions, we should recover the main result of this PR in the case I := ℕ, but I think it is important to develop slightly more general results (both in terms of the index set I and the bifunctor), because at some point, I would like to consider tensor products of unbounded complexes...

@kim-em
Copy link
Contributor Author

kim-em commented Sep 24, 2023

@joelriou, great to hear, I look forward to seeing what you come up with. Please feel free to close this PR either immediately or later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
please-adopt Inactive PR (would be valuable to adopt) t-category-theory Category theory
Projects
None yet
Development

Successfully merging this pull request may close these issues.