add weak.linter.flexible = true to lakefile.toml
#52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmontesi
approved these changes
Aug 28, 2025
|
Very nice! 👏 |
fmontesi
pushed a commit
that referenced
this pull request
Sep 20, 2025
thomaskwaring
pushed a commit
to thomaskwaring/cslib_SKI
that referenced
this pull request
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables Mathlib's flexible linter, a generalized version of checking for non-terminal
simp. As part of this PR I have removed every non-terminalsimpdetected by the linter.There is one minor category of false positive I encountered, which is when
<;> simpis followed by the rest of a proof. In this case the linter can be suppressed locally or you can slightly reorder a proof. I counted only five occurrences (and some of these didn't needsimpanyway). I think that the proof stability is worth this uncommon and minor inconvenience.Side note:
Bisimulation.traceEq_not_bisimwas painful to edit performance-wise! Vim consistently froze on me while trying to usesimp?in the middle of it.