Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make command line consistent (part 1) #65

Merged
merged 1 commit into from
Mar 23, 2022
Merged

fix: make command line consistent (part 1) #65

merged 1 commit into from
Mar 23, 2022

Conversation

lovettchris
Copy link
Contributor

Note: in order to ensure I do not break the vscode-lean4 extension I will do this in 2 stages. First is to add only new options then I can move vscode extension over to those then later to remove the old options (-NoMenu and -PromptOnError).

Chris Lovett: From your discussion in leanprover/vscode-lean4#151 let me summarize:

  • add powershell -NoModifyPath to map to the no-modify-path elan-init option (hmmm, the vscode extension probably should be using this option).
  • remove -PromptOnError since elan-init doesn't have that option (and do this part in vscode extension).
  • change -NoPrompt to -NoMenu to match the -no-prompt option in elan-init.

Sebastian Ullrich: Okay, that sounds acceptable. Whether the extension should modify the path is a good question. I think people will expect leanto work from their cmdline as well after installation.

@lovettchris
Copy link
Contributor Author

Thanks, the matching vscode-lean4 PR is here: leanprover/vscode-lean4#158

@lovettchris lovettchris deleted the clovett/fix_cmd_line_args branch March 23, 2022 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants