-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: replace quickstart leanpkg info with info about lake. #842
Conversation
…dditional compile flag "-ftls-model=local-exec". I think cmake can easily do this just using target_compile_options.
Thanks for your contribution! Please make sure to follow our Commit Convention. |
…works on Windows (outside of msys2).
I've cherry-picked the resolved parts onto master in c3a9860. |
@Kha , rats, I really wanted to get rid of the user having to manually run curl https://raw.githubusercontent.com/leanprover/elan/master/elan-init.sh which is not needed if you just start with the VS code extension and let it do that for you. |
I agree, see updated quickstart.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Happy to merge as soon as the fix is deployed.
Co-authored-by: Sebastian Ullrich <sebasti@nullri.ch>
No, I meant the "Press ENTER key to start Lean" part. |
I see the prompt is still there in vscode-lean4, but I'm not entirely sure about its purpose |
Ah, yes, I was going to remove it by auto-exiting the process, then I wondered about "error conditions", if the elan install fails there will be an error message in that output window, and if I auto-close it the user won't know why it failed... |
Then, should we restrict it to non-zero exit codes from the installer? |
time to tell folks how to use lake.