Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: replace quickstart leanpkg info with info about lake. #842

Merged
merged 46 commits into from
Mar 12, 2022
Merged

doc: replace quickstart leanpkg info with info about lake. #842

merged 46 commits into from
Mar 12, 2022

Conversation

lovettchris
Copy link
Contributor

@lovettchris lovettchris commented Dec 3, 2021

time to tell folks how to use lake.

…dditional compile flag "-ftls-model=local-exec". I think cmake can easily do this just using target_compile_options.
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2021

Thanks for your contribution! Please make sure to follow our Commit Convention.

doc/dev/index.md Outdated Show resolved Hide resolved
@Kha Kha linked an issue Dec 3, 2021 that may be closed by this pull request
doc/quickstart.md Outdated Show resolved Hide resolved
doc/setup.md Outdated Show resolved Hide resolved
doc/make/msys2.md Outdated Show resolved Hide resolved
@Kha
Copy link
Member

Kha commented Dec 19, 2021

I've cherry-picked the resolved parts onto master in c3a9860.

@lovettchris
Copy link
Contributor Author

I've cherry-picked the resolved parts onto master in c3a9860.

@Kha , rats, I really wanted to get rid of the user having to manually run curl https://raw.githubusercontent.com/leanprover/elan/master/elan-init.sh which is not needed if you just start with the VS code extension and let it do that for you.

@lovettchris
Copy link
Contributor Author

I agree, see updated quickstart.md

Copy link
Member

@Kha Kha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Happy to merge as soon as the fix is deployed.

doc/quickstart.md Outdated Show resolved Hide resolved
doc/quickstart.md Outdated Show resolved Hide resolved
lovettchris and others added 2 commits January 21, 2022 12:52
Co-authored-by: Sebastian Ullrich <sebasti@nullri.ch>
@lovettchris
Copy link
Contributor Author

lovettchris commented Jan 21, 2022 via email

@leodemoura leodemoura merged commit 6dc5761 into leanprover:master Mar 12, 2022
@lovettchris lovettchris deleted the clovett/fixdocs branch March 12, 2022 00:42
@Kha
Copy link
Member

Kha commented Mar 12, 2022

Yes, see https://github.com/lovettchris/vscode-lean4/blob/master/lean4-infoview/src/infoview/main.tsx#L57

No, I meant the "Press ENTER key to start Lean" part.

@Kha
Copy link
Member

Kha commented Mar 12, 2022

I see the prompt is still there in vscode-lean4, but I'm not entirely sure about its purpose

@lovettchris
Copy link
Contributor Author

Ah, yes, I was going to remove it by auto-exiting the process, then I wondered about "error conditions", if the elan install fails there will be an error message in that output window, and if I auto-close it the user won't know why it failed...

@Kha
Copy link
Member

Kha commented Mar 16, 2022

Then, should we restrict it to non-zero exit codes from the installer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch docs to Lake
7 participants