Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme.md: redundant example code when expected 2 different examples #19

Closed
pmknyc opened this issue Jul 18, 2018 · 1 comment
Closed
Labels

Comments

@pmknyc
Copy link

pmknyc commented Jul 18, 2018

Referring to file:
learn-co-curriculum/ttt-1-welcome-rb-v-000/readme.md

Text needing correction from this file is pasted below the **** line.
The lecture leads reader to expect 2 different examples of error code but the same example shows up twice. I'm not going to suggest a specific edit. I can rerun the lab and produce different error output but some errors I produced might be confusing for some students at this early stage of the course (and I'm a newbie too!). So, it would be great if an instructor or more experienced coder produces new example error code to for 2 distinct examples in the readme file.
:-)


  1. Make sure you're printing "Welcome to Tic Tac Toe!" exactly.

When you run learn you might see failing tests even though your program seemingly works. The failures might read something like:

1) lib/welcome.rb prints "Welcome to Tic Tac Toe!"
   Failure/Error: load './lib/welcome.rb'
     #<IO:0x007fa2b28325a0> received :puts with unexpected arguments
       expected: ("Welcome to Tic Tac Toe!")
            got: ("Welcome to Tic Tac Toe")
   # ./lib/welcome.rb:4:in `puts'

Or something that looks like:

1) lib/welcome.rb prints "Welcome to Tic Tac Toe!"
   Failure/Error: load './lib/welcome.rb'
     #<IO:0x007fa2b28325a0> received :puts with unexpected arguments
       expected: ("Welcome to Tic Tac Toe!")
            got: ("Welcome to tic tac toe!")
   # ./lib/welcome.rb:4:in `puts'
drakeltheryuujin added a commit that referenced this issue Sep 5, 2018
@drakeltheryuujin
Copy link
Contributor

Thank you for spotting this issue and providing feedback.

We have updated the materials and believe your issue to have been resolved. If you do not believe that this issue has been addressed, please re-open this issue. 💙

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants
@drakeltheryuujin @pmknyc and others