Skip to content

Remove namespace directives from util headers #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 4, 2025

Conversation

aobolensk
Copy link
Member

@aobolensk aobolensk commented Jul 4, 2025

  • drop using namespace ppc::task from func/perf test headers
  • drop using namespace ppc::performance from perf test header
  • qualify names in util helpers with their namespaces

@aobolensk aobolensk requested a review from allnes as a code owner July 4, 2025 12:23
@allnes allnes enabled auto-merge July 4, 2025 12:27
Copy link
Contributor

github-actions bot commented Jul 4, 2025

Coverage report is available for download
here

Copy link

codecov bot commented Jul 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.57%. Comparing base (8b3e8fb) to head (7479dea).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #520   +/-   ##
=======================================
  Coverage   94.57%   94.57%           
=======================================
  Files          11       11           
  Lines         350      350           
  Branches      117      117           
=======================================
  Hits          331      331           
  Misses          5        5           
  Partials       14       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@allnes allnes added this pull request to the merge queue Jul 4, 2025
auto-merge was automatically disabled July 4, 2025 15:36

Pull Request is not mergeable

Merged via the queue into master with commit 94f2a37 Jul 4, 2025
81 checks passed
@aobolensk aobolensk deleted the codex/remove-using-directives-and-update-code branch July 7, 2025 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants