New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translation updates #5485
Translation updates #5485
Conversation
…ent while keeping the file name context
a6b6445
to
cd6c98f
Compare
Codecov Report
@@ Coverage Diff @@
## 0.17.x #5485 +/- ##
==========================================
+ Coverage 61.98% 62.33% +0.34%
==========================================
Files 118 118
Lines 6582 6582
==========================================
+ Hits 4080 4103 +23
+ Misses 2502 2479 -23
Continue to review full report at Codecov.
|
OK, we are not done with this, yet... This is what the Coach tools looks like after updating to the latest content pack in Spanish Strings still in English:
Disregard the strings with orange overlay, as that is a different issue (already reported), which we have to correct nevertheless... 😉 @mrpau-eduard @benjaoming I believe we should correct this too, before releasing 0.17.2. |
Some of these examples are unfortunately from JS libraries that aren't translated:
I've opened #5496 for the two others. |
Summary
msgids
for generating translation sourcesTODO
If not all TODOs are marked, this PR is considered WIP (work in progress)
Reviewer guidance
Let me know if I missed something in the way we generate msgids!
Issues addressed
#5477