Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation updates #5485

Merged
merged 11 commits into from Jul 23, 2017
Merged

Conversation

benjaoming
Copy link
Contributor

@benjaoming benjaoming commented Jul 22, 2017

Summary

  • Documentation
  • Make target msgids for generating translation sources
  • Do not hide "IGNORE_PATTERNS" in a Python file, moved them to the Makefile
  • Adds the sources to the repo so we can track them moving forwards

TODO

If not all TODOs are marked, this PR is considered WIP (work in progress)

  • Has documentation been written/updated?
  • Have you written release notes for the upcoming release?

Reviewer guidance

Let me know if I missed something in the way we generate msgids!

Issues addressed

#5477

@benjaoming benjaoming added this to the 0.17.2 milestone Jul 22, 2017
@benjaoming benjaoming self-assigned this Jul 22, 2017
@codecov
Copy link

codecov bot commented Jul 22, 2017

Codecov Report

Merging #5485 into 0.17.x will increase coverage by 0.34%.
The diff coverage is 93.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           0.17.x    #5485      +/-   ##
==========================================
+ Coverage   61.98%   62.33%   +0.34%     
==========================================
  Files         118      118              
  Lines        6582     6582              
==========================================
+ Hits         4080     4103      +23     
+ Misses       2502     2479      -23
Impacted Files Coverage Δ
kalite/i18n/management/commands/makemessages.py 95.83% <93.75%> (+95.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc1d108...c6d6daa. Read the comment docs.

@benjaoming benjaoming changed the base branch from develop to 0.17.x July 22, 2017 09:42
@benjaoming benjaoming merged commit c5b6598 into learningequality:0.17.x Jul 23, 2017
@radinamatic
Copy link
Member

OK, we are not done with this, yet...

This is what the Coach tools looks like after updating to the latest content pack in Spanish

virtualbox_ubuntu17 04_28_07_2017_19_06_18

Strings still in English:

All selected inside the topic selector and the Submit button.
Search string inside the search field.
N/A value for the summary of total hours on content compared to total hours connected.
Key string for the tabular report colors.

Disregard the strings with orange overlay, as that is a different issue (already reported), which we have to correct nevertheless... 😉

@mrpau-eduard @benjaoming I believe we should correct this too, before releasing 0.17.2.

@benjaoming
Copy link
Contributor Author

@radinamatic

Some of these examples are unfortunately from JS libraries that aren't translated:

  • All selected is from node_modules/bootstrap-multiselect/dist/js/bootstrap-multiselect.js
  • Search is from node_modules/bootstrap-multiselect/dist/js/bootstrap-multiselect.js

I've opened #5496 for the two others.

@benjaoming benjaoming deleted the translation-updates branch December 7, 2017 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants