-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quick fix for resource titles #5509
Quick fix for resource titles #5509
Conversation
Codecov Report
@@ Coverage Diff @@
## 0.17.x #5509 +/- ##
=======================================
Coverage 62.77% 62.77%
=======================================
Files 117 117
Lines 6555 6555
=======================================
Hits 4115 4115
Misses 2440 2440
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also very clean and simple, no risks here it would seem!
No errors and 100% coverage, looks good! |
Nice fix @mrpau-eugene! 👍 Not sure if there is possibility to fix these remaining strings, it would be a real bonus... 😉 Otherwise make sure to grab the latest PO files from Crowdin, as I've translated the |
@rtibbles is there anyway to internationalize the texts that @radinamatic highlighted which are: I only managed to translate the Btw @radinamatic can you check if the translation for |
@mrpau-eugene looks like you can configure the |
@rtibbles thanks! |
Summary
When trying to select a
Theme
insideTeach
tab and submits it, theShow Tabular Reports
displays resource titles in English.Reviewer guidance
Just a quick fix.
Issues addressed
#5494
pinging @radinamatic @benjaoming for this