New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick fix for resource titles #5509

Merged
merged 1 commit into from Aug 24, 2017

Conversation

Projects
None yet
4 participants
@mrpau-eugene
Member

mrpau-eugene commented Aug 23, 2017

Summary

When trying to select a Theme inside Teach tab and submits it, the Show Tabular Reports displays resource titles in English.

Reviewer guidance

Just a quick fix.

Issues addressed

#5494

pinging @radinamatic @benjaoming for this

@mrpau-eugene mrpau-eugene added this to the 0.17.2 milestone Aug 23, 2017

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Aug 23, 2017

Codecov Report

Merging #5509 into 0.17.x will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           0.17.x    #5509   +/-   ##
=======================================
  Coverage   62.77%   62.77%           
=======================================
  Files         117      117           
  Lines        6555     6555           
=======================================
  Hits         4115     4115           
  Misses       2440     2440
Impacted Files Coverage Δ
kalite/coachreports/api_views.py 93.07% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7868918...0306924. Read the comment docs.

codecov bot commented Aug 23, 2017

Codecov Report

Merging #5509 into 0.17.x will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           0.17.x    #5509   +/-   ##
=======================================
  Coverage   62.77%   62.77%           
=======================================
  Files         117      117           
  Lines        6555     6555           
=======================================
  Hits         4115     4115           
  Misses       2440     2440
Impacted Files Coverage Δ
kalite/coachreports/api_views.py 93.07% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7868918...0306924. Read the comment docs.

@mrpau-eugene mrpau-eugene requested a review from radinamatic Aug 23, 2017

@benjaoming

Also very clean and simple, no risks here it would seem!

@benjaoming benjaoming modified the milestones: 0.17.3, 0.17.2 Aug 24, 2017

@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming Aug 24, 2017

Member

No errors and 100% coverage, looks good!

Member

benjaoming commented Aug 24, 2017

No errors and 100% coverage, looks good!

@benjaoming benjaoming merged commit 1c068e2 into learningequality:0.17.x Aug 24, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 62.77%)
Details
codecov/project 62.77% (+0%) compared to f6b3ef4
Details
@radinamatic

This comment has been minimized.

Show comment
Hide comment
@radinamatic

radinamatic Aug 28, 2017

Contributor

Nice fix @mrpau-eugene! 👍

Not sure if there is possibility to fix these remaining strings, it would be a real bonus... 😉

Otherwise make sure to grab the latest PO files from Crowdin, as I've translated the Color legend by @benjaoming , but it's still showing in English.

w7 start running - oracle vm virtualbox_541

Contributor

radinamatic commented Aug 28, 2017

Nice fix @mrpau-eugene! 👍

Not sure if there is possibility to fix these remaining strings, it would be a real bonus... 😉

Otherwise make sure to grab the latest PO files from Crowdin, as I've translated the Color legend by @benjaoming , but it's still showing in English.

w7 start running - oracle vm virtualbox_541

@mrpau-eugene

This comment has been minimized.

Show comment
Hide comment
@mrpau-eugene

mrpau-eugene Aug 29, 2017

Member

@rtibbles is there anyway to internationalize the texts that @radinamatic highlighted which are: All selected and Search, without touching the bootstrap-multiselect files?

I only managed to translate the Submit string since it wasn't wrapped with an _.

Btw @radinamatic can you check if the translation for Color Legend is correct in the crowdin?
image

Member

mrpau-eugene commented Aug 29, 2017

@rtibbles is there anyway to internationalize the texts that @radinamatic highlighted which are: All selected and Search, without touching the bootstrap-multiselect files?

I only managed to translate the Submit string since it wasn't wrapped with an _.

Btw @radinamatic can you check if the translation for Color Legend is correct in the crowdin?
image

@rtibbles

This comment has been minimized.

Show comment
Hide comment
@rtibbles

rtibbles Aug 29, 2017

Member

@mrpau-eugene looks like you can configure the allSelectedText option http://davidstutz.github.io/bootstrap-multiselect/#configuration-options-allSelectedText and the http://davidstutz.github.io/bootstrap-multiselect/#configuration-options-nonSelectedText option? I think that would be the way to internationalize it. Assuming I have got the right plugin here!

Member

rtibbles commented Aug 29, 2017

@mrpau-eugene looks like you can configure the allSelectedText option http://davidstutz.github.io/bootstrap-multiselect/#configuration-options-allSelectedText and the http://davidstutz.github.io/bootstrap-multiselect/#configuration-options-nonSelectedText option? I think that would be the way to internationalize it. Assuming I have got the right plugin here!

@mrpau-eugene

This comment has been minimized.

Show comment
Hide comment
@mrpau-eugene
Member

mrpau-eugene commented Aug 30, 2017

@rtibbles thanks!

@mrpau-eugene mrpau-eugene deleted the mrpau:hotfix/5494-some-resources-still-displaying-in-english branch Nov 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment