Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick fix for resource titles #5509

Conversation

mrpau-eugene
Copy link
Contributor

Summary

When trying to select a Theme inside Teach tab and submits it, the Show Tabular Reports displays resource titles in English.

Reviewer guidance

Just a quick fix.

Issues addressed

#5494

pinging @radinamatic @benjaoming for this

@mrpau-eugene mrpau-eugene added this to the 0.17.2 milestone Aug 23, 2017
@codecov
Copy link

codecov bot commented Aug 23, 2017

Codecov Report

Merging #5509 into 0.17.x will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           0.17.x    #5509   +/-   ##
=======================================
  Coverage   62.77%   62.77%           
=======================================
  Files         117      117           
  Lines        6555     6555           
=======================================
  Hits         4115     4115           
  Misses       2440     2440
Impacted Files Coverage Δ
kalite/coachreports/api_views.py 93.07% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7868918...0306924. Read the comment docs.

Copy link
Contributor

@benjaoming benjaoming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also very clean and simple, no risks here it would seem!

@benjaoming benjaoming modified the milestones: 0.17.3, 0.17.2 Aug 24, 2017
@benjaoming
Copy link
Contributor

No errors and 100% coverage, looks good!

@benjaoming benjaoming merged commit 1c068e2 into learningequality:0.17.x Aug 24, 2017
@radinamatic
Copy link
Member

Nice fix @mrpau-eugene! 👍

Not sure if there is possibility to fix these remaining strings, it would be a real bonus... 😉

Otherwise make sure to grab the latest PO files from Crowdin, as I've translated the Color legend by @benjaoming , but it's still showing in English.

w7 start running - oracle vm virtualbox_541

@mrpau-eugene
Copy link
Contributor Author

mrpau-eugene commented Aug 29, 2017

@rtibbles is there anyway to internationalize the texts that @radinamatic highlighted which are: All selected and Search, without touching the bootstrap-multiselect files?

I only managed to translate the Submit string since it wasn't wrapped with an _.

Btw @radinamatic can you check if the translation for Color Legend is correct in the crowdin?
image

@rtibbles
Copy link
Member

@mrpau-eugene looks like you can configure the allSelectedText option http://davidstutz.github.io/bootstrap-multiselect/#configuration-options-allSelectedText and the http://davidstutz.github.io/bootstrap-multiselect/#configuration-options-nonSelectedText option? I think that would be the way to internationalize it. Assuming I have got the right plugin here!

@mrpau-eugene
Copy link
Contributor Author

@rtibbles thanks!

@mrpau-eugene mrpau-eugene deleted the hotfix/5494-some-resources-still-displaying-in-english branch November 16, 2017 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants