Refactor login api endpoint to auth api endpoint #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added GET auth api endpoint to get user information from authorisation token found in the authorization request header Added tests GET auth api endpoint in request directory Refactor existing source code with jwtUtils.js where getReqAuthToken and verifyAuthToken are their own separate methods
JonathanLeeWH
added
enhancement
|
#62 closed as JWT Authentication will be replaced by firebase Authentication which require a rewrite in the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GETauthapi endpoint to get user information from authorisation token found in the authorization request headerGETauthapi endpoint in request directoryjwtUtils.jswheregetReqAuthTokenandverifyAuthTokenare their own separate methodsAfter some considerations, this will be the last update to the
authAPI endpoint before migration to firebase Authentication #68.Originally, there were plans to improve on the JWT authentication such as adding expiry to the JWT tokens for security, adding refresh tokens, etc but this will be replaced with firebase Authentication which is planned for the release after the
0.1.0release.As such #62 will be closed after this PR.