Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ledger-reconcile-default-date-format setting is not respected #408

Closed
bcc32 opened this issue Mar 20, 2024 · 2 comments · Fixed by #412
Closed

ledger-reconcile-default-date-format setting is not respected #408

bcc32 opened this issue Mar 20, 2024 · 2 comments · Fixed by #412

Comments

@bcc32
Copy link
Collaborator

bcc32 commented Mar 20, 2024

Setting ledger-reconcile-default-date-format to something different than
ledger-default-date-format seems to have no effect (the dates in reconcile
buffers still look like the latter). It looks like the former variable is not
actually used anywhere.

@purcell
Copy link
Member

purcell commented Mar 25, 2024

Is there any good reason to support different date formats for different areas of functionality? Seems like everyone would be better off if we just used one, but perhaps I'm missing something.

@bcc32
Copy link
Collaborator Author

bcc32 commented Mar 25, 2024

For reconciling, it might be handy to have ledger display the same date format as, e.g., your online banking website does. Or perhaps it is overly verbose to display the year when reconciling a credit card statement from the last month? I don't know why this variable was introduced in the first place, but that seems like a logical explanation to me—I've never seen a credit card statement that uses ISO8601 :)

Part of the confusion, at least for me, is that it's not obvious whether a given "date format" variable is used for output or input, or both.

bcc32 added a commit to bcc32/ledger-mode that referenced this issue Apr 3, 2024
@bcc32 bcc32 closed this as completed in 3c67d52 Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants