Skip to content

Conversation

afh
Copy link
Member

@afh afh commented Mar 24, 2023

  • Prefer semantic tags over generic tags with id attribute
  • Add description and viewport meta information
  • Address issues from validator.w3.org, e.g. missing lang attribute on html tag

The changes should only have minimal, hardly noticeable visual effects.

* Prefer semantic tags over generic tags with id attribute
* Add description and viewport meta information
* Address issues from validator.w3.org, e.g. missing lang attribute
  on html tag
@afh afh requested review from jwiegley and tbm March 24, 2023 22:00
@afh afh self-assigned this Mar 24, 2023
@afh afh merged commit 1f4456b into ledger:master Mar 24, 2023
@afh afh deleted the modernize-html branch March 24, 2023 23:27
@afh
Copy link
Member Author

afh commented Mar 24, 2023

Thanks, @jwiegley. With this PR merged and deployed the Nu Html Checker has no errors or warnings to show 🙂

ℹ️ There can be a period (should be around 4 hours) where browsers still have the old CSS cached and ledger-cli.org will look unstyled. If that is the case one can update the CSS manually by visiting https://ledger-cli.org/stylesheets/site.css and then reloading https://ledger-cli.org/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants