Moving master to Pgobject #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--HG-- rename : LedgerSMB/DBObject/App_Module.pm => LedgerSMB/App_Module.pm
…w we test on type
|
I think this leads to cleaner code and hopefully attracts more people to use code that can be shared between projects. |
| =head1 SYNPOSIS | ||
|
|
||
| This is like DBObject but uses the PGObject::Simple for base functionality. | ||
|
|
There was a problem hiding this comment.
Would be nice if there was a comment block enumerating what needs to be done to eliminate this file. Since it's a compatability wrapper, it probably has no long-term place in the code base.
ehuelsmann
added a commit
that referenced
this pull request
Oct 9, 2015
* Fix the balance sheet report in case GIFI isn't used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves Master to the PGObject framework.
For 1.5, the target is to rewrite the financial logic including payments and reconciliation.
I think 1.6 can shoot for getting rid of LedgerSMB::PGOld (replacement for LedgerSMB::PGObject).