Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options #5

Closed
ghost opened this issue Jan 15, 2012 · 12 comments
Closed

Options #5

ghost opened this issue Jan 15, 2012 · 12 comments

Comments

@ghost
Copy link

ghost commented Jan 15, 2012

How can you set options like autoplay for a video?

This is the URL I'm trying: //noembed.com/embed?url=http%3A%2F%2Fyoutu.be%2FDT-dxG4WWf4&autoplay=1&callback=?

@leedo
Copy link
Owner

leedo commented Jan 15, 2012

Currently there is no auto-play option. It is definitely something that could be added, assuming youtube supports it.

@leedo
Copy link
Owner

leedo commented Jan 15, 2012

The autoplay option should work now with this commit: 2e9d276

@leedo leedo closed this as completed Jan 15, 2012
@ghost
Copy link
Author

ghost commented Jan 15, 2012

Thanks!

Can you also enable it for Vimeo?

I am thinking, wouldn't it be more convenient to just pass through any query parameters passed to the original, encoded URL?

Like:

http://vimeo.com/34896859?autoplay=1 encoded becomes: //noembed.com/embed?url=http%3A%2F%2Fvimeo.com%2F34896859%3Fautoplay%3D1&callback=? for Noembed.

This in accordance with the official Vimeo noembed API too, I guess: http://vimeo.com/api/docs/oEmbed

@leedo
Copy link
Owner

leedo commented Jan 15, 2012

I think passing through params is ideal, but it will require some refactoring. I'll just add autoplay to vimeo for now.

@leedo
Copy link
Owner

leedo commented Jan 15, 2012

I've added the autoplay param to Vimeo.

After more thought I don't think passing through all params makes sense, especially for non-oembed enabled sites. My plan is to add an option for sources (e.g. Vimeo) to define a list of params that will be passed through.

@ghost
Copy link
Author

ghost commented Apr 13, 2012

Any news on this?

I want to remove the title and portrait of a Vimeo video because the title is already in the markup above the video.

@ghost
Copy link
Author

ghost commented Apr 13, 2012

Any news on this?

I want to remove the title, byline and portrait of a Vimeo video because the title is already in the markup above the video.

@leedo
Copy link
Owner

leedo commented Apr 14, 2012

I've made it so we can define options that should be passed through. So you want title,byline, andportrait` parameters passed through to Vimeo?

@ghost
Copy link
Author

ghost commented Apr 14, 2012

That's correct. With the changes, I've managed to disable title, byline and portrait.

Thank you for your quick response and actions!

@ghost
Copy link
Author

ghost commented Apr 23, 2012

While using the Vimeo player API, I've noticed that the player_id parameter doesn't get passed through. Could this one be enabled too?

@leedo
Copy link
Owner

leedo commented Apr 23, 2012

This should be getting pass through now. Thanks!

@ghost
Copy link
Author

ghost commented Apr 24, 2012

Great! Thank you too.

ryanfb pushed a commit to ryanfb/noembed that referenced this issue May 26, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant