Add deepCollapseChildren prop for allowing deeply collapsed children #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a user specifies a depth to be collapsed, the intention is to make the JSON tidy so it is easy to visually parse. Currently when the user then expands an item, it expands all its children fully, which is rarely the intention. I think this should collapse all children beyond the depth level, so that when the items are opened up the children are collapsed. That said, for backwards compatibility I've implemented this as a new prop, defaulting to false, so that anyone upgrading won't see a change in behaviour.
Let the user know about the new prop for collapsing all children at the level below the `deep` prop passed.
|
I've tested this briefly locally and it does as intended, but only found this codebase today so can't guarantee there aren't any side effects, so recommend testing by the maintainers. |
This was referenced Aug 17, 2021
|
A great feature. Can you help update the demo? |
leezng
approved these changes
Aug 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is also a PR for the
devbranch in #131, this PR is for the1.xbranchWhen a user specifies a depth to be collapsed, the intention is to make the JSON tidy so it is easy to visually parse.
Currently the
deepprop only collapses at the specific level passed, and when a user opens that depth, all children are fully open.I think this should collapse all children beyond the depth level, so that when the items are opened up the children are collapsed.
That said, for backwards compatibility I've implemented this as a new prop, defaulting to false, so that anyone upgrading won't see a change in behaviour.
I'm not sure on the naming of the prop, but feel like this would be beneficial and would resolve #125.