Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle includeSources in CalculateManifest mode #42

Merged
merged 3 commits into from
Jul 25, 2021

Conversation

lefou
Copy link
Owner

@lefou lefou commented Jul 25, 2021

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2021

Codecov Report

Merging #42 (37c8de6) into main (1900b52) will decrease coverage by 15.61%.
The diff coverage is 11.11%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main      #42       +/-   ##
===========================================
- Coverage   97.33%   81.72%   -15.62%     
===========================================
  Files           2        3        +1     
  Lines          75       93       +18     
  Branches        1        1               
===========================================
+ Hits           73       76        +3     
- Misses          2       17       +15     
Impacted Files Coverage Δ
.../src/de/tobiasroeser/mill/osgi/internal/copy.scala 0.00% <0.00%> (ø)
...c/de/tobiasroeser/mill/osgi/OsgiBundleModule.scala 100.00% <100.00%> (+2.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1900b52...37c8de6. Read the comment docs.

@lefou lefou merged commit ccfd1f7 into main Jul 25, 2021
@lefou lefou deleted the include-sources branch July 25, 2021 14:29
@lefou lefou added this to the after 0.3.2 milestone Jul 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants