[info] cppcheck 2.7 makes a debug build fail

[jmarrec]

This is only for std::string_view. I built cppcheck today from main, at danmar/cppcheck@24e9859

/home/julien/Software/Others/json2cpp/src/json2cpp.hpp:20:48: performance: Function parameter 'document_name' should be passed by const reference. [passedByValue]
compile_results compile(const std::string_view document_name, const nlohmann::json &json);
                                               ^

I realize this is idiomatic, but I thought you may be interested in knowing that currently it will fail, as it is enabled by default (provided you have cppcheck installed already on your system)

Note: I opened a PR to cppcheck to allow passing std::string_view by value: danmar/cppcheck#3817

[jmarrec]

(feel free to close this "issue" that isn't really one)

[lefticus]

Thanks for the note. I'm not entirely sure which version of cppcheck is being used on the CI (it is running cppcheck and clangt-tidy on CI as you may have noticed)

[lefticus]

Great, now all of my tests are failing because we're using cppcheck 2.7 by default now.

[lefticus]

@aminya can you provide insight here as to how best mitigate this bug in cppcheck 2.7, which is now the default installed with project_options it seems?

I don't see any way to pass extra parameters to cppcheck. I could force it back down to 2.6? Putting a linter comment in each location seems like a very bad idea.

[aminya]

The build fails because you have enabled WARNINGS_AS_ERRORS. I never personally use this as I do not require an external force to address them. Sometimes warnings are genuine warnings and not errors.

cppcheck is not installed by default as part of project_options. If your project doesn't work with cppcheck, you can disable it in CMakeLists.txt. You have enabled it by default because you are using dynamic_project_options, which hides the options.
https://github.com/cpp-best-practices/project_options#usage

You can also pass the version of cppcheck you want to setup-cpp

json2cpp/.github/workflows/ci.yml

Line 146 in 78b075c

cppcheck: true

[lefticus]

My point is that right now we have 2 options: use cpp_check, or don't use cpp_check. We have no way of setting individual flags or options like we do with gcc/clang/msvc/clang-tidy.

Do you think it's worth adding a configuration option to to project_options for this?

[lefticus]

I never personally use this as I do not require an external force to address them. Sometimes warnings are genuine warnings and not errors.

Interesting, do you manually sort through the logs for each compiler and platform that is checked to see if any warnings are generated?

[jmarrec]

FYI, danmar/cppcheck#3817 was merged upstream.

[lefticus]

Thanks @jmarrec . I still feel like I just have to disable this check. clang-tidy provides its own guidance, and actually knows something about the types.

[lefticus]

Fixed with #8