Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Device unique id parameter #75

Closed
leikoilja opened this issue Apr 13, 2021 · 4 comments · Fixed by #145
Closed

Device unique id parameter #75

leikoilja opened this issue Apr 13, 2021 · 4 comments · Fixed by #145
Labels
feature New feature or request

Comments

@leikoilja
Copy link
Owner

Let's find a way to extract a unique ID from homegraph or eureka endpoint to pass it for each of devices

@leikoilja leikoilja added the feature New feature or request label Apr 13, 2021
@leikoilja leikoilja changed the title Pass device id parameter Device unique id parameter Apr 13, 2021
@ArnyminerZ
Copy link
Collaborator

ArnyminerZ commented Jun 6, 2021

I was taking a look at GHLAPI to see which element would fit our needs. And I think the best options are:

  • cloud_device_id: which may not be the best option, since it seems a pretty private ID, so a copy-paste from the log may show up this info.
  • public_key: may be a good option, states that it's public, so there won't be any privacy issues, and I believe it should be unique, but it might be a bit too large.
  • ssdp_udn: Not sure what this is
  • uma_client_id: Not sure what this is

There's also the AppDeviceID option, which seems to be unique.

What do you think would be the best option?

@KapJI
Copy link
Collaborator

KapJI commented Jun 7, 2021

cloud_device_id sounds good. Or just mac_address, that's a common practice.

@leikoilja
Copy link
Owner Author

Good investigation, @ArnyminerZ 🙌
AppDeviceID does not seem to be unique thou.
Seems like both cloud_device_id and mac_address are present in eureka endpoint, so both seems to be legitimate options. I am in favour of mac_address thou.

@ArnyminerZ
Copy link
Collaborator

I'd also go for mac_address, seems more private and less hackable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants