Remove hard dependency on quicklisp #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cxxxr
reviewed
Feb 10, 2024
Comment on lines
+211
to
+213
| ((ocicl-dl (eval `(let ((,ocicl-dl t)) | ||
| (dolist (s system-names) | ||
| (asdf:load-system s)))))) |
There was a problem hiding this comment.
Can the uiop:symbol-call be used instead of eval?
|
I made this today, and hopefully we can make something like this a
standard. I've submitted to quicklisp:
https://github.com/atgreen/trivial-system-loader
…On Sat, Feb 10, 2024 at 10:19 AM cxxxr ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In lsp-api.lisp
<#11 (comment)>:
> + ((ocicl-dl (eval `(let ((,ocicl-dl t))
+ (dolist (s system-names)
+ (asdf:load-system s))))))
Can the uiop:symbol-call be used instead of eval?
—
Reply to this email directly, view it on GitHub
<#11 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAV7CM7ZYDCD5QCYMWFW7DYS6FWXAVCNFSM6AAAAABDCVKL2OVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQNZTG4ZDSMRRGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
It's nice libarry. |
|
It is my understanding that this PR has been resolved by #12 and can be closed as is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes the hard dependency on quicklisp for people who use ocicl instead of quicklisp.
As a last-ditch effort, it will just use asdf:load-system when neither is available.