Repository navigation
RFC: Request to reorganize and fix CMake configuration while reducing overall debt. #3542
Replies: 4 comments
|
The last time we refactored the CMake file it was the introduction of Ninja, which added a lot of benefit but also broke installers and disrupted the dev us for weeks. Clear drawbacks, but also a clear ROI that made it worth it. The acceptable bar for disruptive changes to a critical system that already works is high.
Can you elaborate on what you mean here? As a developer or end-user of Lemonade, what specific benefits will I see from this reduction in overhead? I can tell you I have no complaints right now. |
Right because most people are using AI to contribute but if you look at it, its massive and unorganized. |
|
Ok I get that. In order to get this done, we need a sufficiently large enough amount of people to beta test the new implementation from both the user side (trying every installer on every platform) and the developer side (implementing a PR e2e on every platform). Please add this criteria to the description and see if you can sign up a sufficient number of testers. |
Sounds good I would 100% agree to this as well. We need to test everything. |
Uh oh!
There was an error while loading. Please reload this page.
Hi Guys,
I believe our cmake file is a little extensive and can be cleaned up.
Currently we define source files inside cmake files, I would like to completely remove that and use our existing structure to auto detect source files, header files, and Mac specific files. I believe this will reduce the overall cmake overhead we have. While I am doing this we can also clean it up and split it into multiple files so when users edit a cmake it can attach the right expert associated to that cmake file. There is another trick we can do is create "projects" or "libraries" and essentially what this does is handle creating the packaging through a cmake function we make like
create_package(PLATFORM_LINUX)basically we are able to modularize the cmake well enough that when someone does edit cmake, if ever, which should be almost never with these changes, they won't need to change packaging or even get close to the packaging cmake files.@jeremyfowers @superm1 @ramkrishna2910
All reactions