Use webpack instead of tsc to output extension-api.ts #1499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ixrock
reviewed
Nov 24, 2020
|
Can't get what this PR fixing / improves? |
|
Ok, @chenhunghan please put next time relevant links in PR/issue description. |
sure, it's a WIP draft so I didn't put too much attention on the description. |
|
@jakolehm checks are passed, please take a look |
Signed-off-by: Hung-Han (Henry) Chen <1474479+chenhunghan@users.noreply.github.com>
Signed-off-by: Hung-Han (Henry) Chen <1474479+chenhunghan@users.noreply.github.com>
…tensions Signed-off-by: Hung-Han (Henry) Chen <1474479+chenhunghan@users.noreply.github.com>
Signed-off-by: Hung-Han (Henry) Chen <1474479+chenhunghan@users.noreply.github.com>
Signed-off-by: Hung-Han (Henry) Chen <1474479+chenhunghan@users.noreply.github.com>
chenhunghan
force-pushed
the
feature/webpack-output-extension
branch
from
f36ba40
to
c2e23bd
Compare
jakolehm
approved these changes
Nov 26, 2020
| extensions: ['.ts', '.tsx', '.js'] | ||
| }, | ||
| plugins: [ | ||
| // In ts-loader's README they said to output a built .d.ts file, |
There was a problem hiding this comment.
I prefer to leave it there as someone else might waste time trying...
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original script
compile:extension-types(introduced in #1387) which usestscto output.d.tsdidn't (completely) resolve issue #1262, becausetsconly transpile.ts/tsxto.jsThe
require('module')/importints/tsxare the same after transpilation. Keepingrequire/importcauses lensapp/generator-lens-ext#13 (see comments) for extension developers, when they try to import modules from@k8slens/extensionsThe PR aims to use WebPack to solve the problem. I added a new
webpack.extensions.ts, and usedwebpack+ts-loaderto pack@k8slens/extensionsas one fileextension-api.jsand output.d.tsjust the same originaltsc.I tried to keep
webpack.extensions.tsas simple as possible, so remove unnecessary settings which are in other more complicated settings such aswebpack.renderer.tsorwebpack.main.tsCloses #1262
Signed-off-by: Hung-Han (Henry) Chen 1474479+chenhunghan@users.noreply.github.com