Fix custom resource loading spinner appears above extensions' cluster menus #2344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Nokel81
force-pushed
the
fix-sidebar-spinner
branch
from
3d55e56
to
e745ccf
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
jim-docker
previously approved these changes
Mar 29, 2021
aleksfront
reviewed
Mar 30, 2021
Nokel81
force-pushed
the
fix-sidebar-spinner
branch
from
97c0b16
to
fc0287d
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
Nokel81
force-pushed
the
fix-sidebar-spinner
branch
from
fc0287d
to
da8ada3
Compare
… menus Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Nokel81
force-pushed
the
fix-sidebar-spinner
branch
from
da8ada3
to
97b2fc7
Compare
Nokel81
added
the
merge/master
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Nokel81
force-pushed
the
fix-sidebar-spinner
branch
from
079b6ed
to
a02671c
Compare
jim-docker
approved these changes
Apr 19, 2021
aleksfront
approved these changes
Apr 20, 2021
Merged
Nokel81
added a commit
that referenced
this pull request
Apr 26, 2021
Merged
Nokel81
removed
the
merge/master
Nokel81
added a commit
that referenced
this pull request
Apr 26, 2021
… menus (#2344) Signed-off-by: Sebastian Malton <sebastian@malton.name>
jakolehm
pushed a commit
that referenced
this pull request
Apr 27, 2021
* Fix: logs data disapearing causing crashes (#2566) Signed-off-by: Sebastian Malton <sebastian@malton.name> * Refactor helm-chart.api and improve kube validation and error handling (#2265) Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix: HPA's not sortable by age (#2565) Signed-off-by: Sebastian Malton <sebastian@malton.name> * Conditionally render status icon for kube meta (#2298) Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix custom resource loading spinner appears above extensions' cluster menus (#2344) Signed-off-by: Sebastian Malton <sebastian@malton.name> * Lens should point to the release docs (#2268) Signed-off-by: Sebastian Malton <sebastian@malton.name> * Refactor the Extensions settings page (#2221) Signed-off-by: Sebastian Malton <sebastian@malton.name> * try and get jest to not core dump Signed-off-by: Sebastian Malton <sebastian@malton.name>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sebastian Malton sebastian@malton.name
Before:
Screen.Recording.2021-03-16.at.1.12.06.PM.mov
After:
Screen.Recording.2021-03-16.at.1.08.36.PM.mov