Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature cassandra timestamp support #680

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Feature cassandra timestamp support #680

wants to merge 2 commits into from

Conversation

sjmittal
Copy link
Contributor

No description provided.

@sjmittal sjmittal mentioned this pull request Apr 27, 2020
Open
andrewstevenson
andrewstevenson reviewed Aug 24, 2020
View reviewed changes
Copy link
Contributor

@andrewstevenson andrewstevenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sjmittal can you add a unit test?

@sjmittal
Copy link
Contributor Author

I checked and right now I don't see any test case written for CassandraTableReader. Actually I have not worked on this since almost beginning of the year.
As per comment: #647 (comment)
The change was very specific to the use case where a column of type timestamp was converted to a Long timestamp. This may not always be the case.

I think a right fix should be for kcql be able to parse cql functions so data could be read from source is any format as we like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewstevenson andrewstevenson andrewstevenson left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sjmittal @andrewstevenson