Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set pipefail when running verilator command #100

Merged
merged 13 commits into from
May 20, 2019
Merged

set pipefail when running verilator command #100

merged 13 commits into from
May 20, 2019

Conversation

leonardt
Copy link
Owner

Fixes sub issue in StanfordAHA/lassen#66 where the verilator command was failing silently

@leonardt leonardt requested a review from Kuree May 15, 2019 17:41
@leonardt leonardt mentioned this pull request May 15, 2019
Closed
@coveralls
Copy link

coveralls commented May 15, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 916

  • 0 of 5 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.09%) to 76.428%
Changes Missing Coverage Covered Lines Changed/Added Lines %
fault/system_verilog_target.py 0 5 0.0%
Files with Coverage Reduction New Missed Lines %
fault/system_verilog_target.py 1 16.38%
Totals Coverage Status
Change from base Build 910: -0.09%
Covered Lines: 1365
Relevant Lines: 1786
💛 - Coveralls

@leonardt leonardt mentioned this pull request May 15, 2019
Merged
@leonardt leonardt changed the base branch from master to sv-file-io May 15, 2019 18:43
@leonardt
Copy link
Owner Author

Changed base to sv-file-io so i could use iverilog

@Kuree
Copy link
Collaborator

Kuree commented May 15, 2019

@leonardt Is it okay to merge now?

@leonardt
Copy link
Owner Author

@Kuree almost, working through a vcs issue

@leonardt leonardt changed the base branch from sv-file-io to master May 20, 2019 15:20
@leonardt leonardt merged commit f220e83 into master May 20, 2019
@leonardt leonardt deleted the patch-pipefail branch November 13, 2019 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kuree Kuree Kuree approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leonardt @coveralls @Kuree