Skip to content

Add initial implementation of skipping verilator build #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2019
Merged

Add initial implementation of skipping verilator build #94

merged 1 commit into from
May 13, 2019

Conversation

Kuree
Copy link
Collaborator

@Kuree Kuree commented May 12, 2019

  • Add a skip verilator option so that TBG can reuse existing binary. In TBG it will be used together with skip_compile=True to skip the magma circuit, verilog, and verilator compilation.
  • Add a test to confirm the functionality.

@Kuree Kuree mentioned this pull request May 12, 2019
Closed
@Kuree Kuree requested a review from leonardt May 12, 2019 19:35
@coveralls
Copy link

Pull Request Test Coverage Report for Build 827

  • 4 of 5 (80.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 77.203%
Changes Missing Coverage Covered Lines Changed/Added Lines %
fault/verilator_target.py 4 5 80.0%
Totals Coverage Status
Change from base Build 819: 0.01%
Covered Lines: 1253
Relevant Lines: 1623
💛 - Coveralls

leonardt
leonardt approved these changes May 13, 2019
View reviewed changes
Copy link
Owner

@leonardt leonardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@leonardt leonardt merged commit c9ae8b0 into master May 13, 2019
@leonardt leonardt deleted the skip_verilator branch May 13, 2019 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leonardt leonardt leonardt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kuree @coveralls @leonardt