desugar more types of for-loops #10
Conversation
Pull Request Test Coverage Report for Build 264
💛 - Coveralls |
|
Actually, don't merge this yet. |
silica/compile.py
Outdated
| tree, list_lens = propagate_types(tree) | ||
| tree, loopvars = desugar_for_loops(tree, list_lens) | ||
|
|
||
| ast_utils.print_ast(tree) |
There was a problem hiding this comment.
Let's take this out before we merge. More generally it would be good to set up some logging infrastructure so we could have these print outs hidden under a DEBUG level. I'll put that on the todo list.
| return "<MemoryType: {}, {}>".format(self.height, self.width) | ||
|
|
||
| def __repr__(self): | ||
| return "<MemoryType: {}, {}>".format(self.height, self.width) |
There was a problem hiding this comment.
We could just have __str__ call __repr__ since right now they're the same. In fact, I think if you only define __repr__, __str__ will default to calling __repr__
| ast.Assign([ast.Name(index, ast.Store())], start), | ||
| ast.While(ast.BinOp(ast.Name(index, ast.Load()), ast.Lt(), stop), | ||
| [ast.Assign([ast.Name(node.target.id, ast.Store())], | ||
| ast.Subscript(node.iter, ast.Index(ast.Name(index, ast.Load()))))] + |
There was a problem hiding this comment.
It looks like travis is unhappy about this Subscript constructor call. Are you using Python 3.6? The AST has had some changes in Python 3, so that could explain the discrepancy if you're not seeing the issue locally. Subscript expects value, slice, ctx (see https://greentreesnakes.readthedocs.io/en/latest/nodes.html#Subscript), so I think this is missing a ctx. I think in this case it would be an ast.Load(), since we're loading the subscripted value and storing into the loop var
veriloggen doesn't seem to support unpacked array syntax
for x in range(1,10,1)for x in range(len(A))for x in X