Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default decimal radix codegen #50

Merged
merged 1 commit into from
Jun 23, 2020
Merged

Add default decimal radix codegen #50

merged 1 commit into from
Jun 23, 2020

Conversation

leonardt
Copy link
Owner

Verilator requires that if we emit a size specifier (e.g. 28'20') that we also emit the radix specifier (it doesn't use decimal by default), so we need 28'd20

@rsetaluri
Copy link
Collaborator

This is the thing inferred by default right? just making sure no existing things will break by making this explicit

@leonardt
Copy link
Owner Author

Correct, this is just making what’s inferred explicit so it should not break any code

@leonardt leonardt merged commit 9a94ff5 into master Jun 23, 2020
@leonardt leonardt deleted the default-radix branch June 23, 2020 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants