Constant Expressions #6
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm going to change the base of the PR to #5 so I can review the changes w.r.t. to that branch |
leonardt
reviewed
Jun 18, 2019
There was a problem hiding this comment.
What is the value in having a separate ConstantExpression versus regular expression? Are there different rules about what you can have? Or is it the same as the expressions you can use normally?
If there's nothing different about them, I would strongly prefer to re-use the expression logic for both so we don't have to duplicate code.
leonardt
reviewed
Jun 18, 2019
| add_executable(parameterized_module tests/parameterized_module.cpp) | ||
| target_link_libraries(parameterized_module gtest_main ${LIBRARY_NAME}) | ||
| add_test(NAME parameterized_module_tests COMMAND parameterized_module) | ||
|
|
There was a problem hiding this comment.
(nit) we can review this new line?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #4 and #5
This branch fully fleshes out constant expressions and adds a test that fully describes a parameterized verilog module.