-
-
Notifications
You must be signed in to change notification settings - Fork 746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix non-legacy backdrop when switching themes and applying Mica or other effect #1094
Conversation
I'm trying this out based on your last comment (nice timing!), but it's setting the entire window to transparent, instead of applying the Mica background to the navigation control |
@nabeelio afaik mica bg is drawn under the window (as this is set through winapi) and then it will be visible on different controls (including window) only when they either don't have background or the background is transparent, so window bg removal is intended. |
@Muniwedesu thanks - that's interesting. I'm on Windows 11. And yes, setting this, it applies the transparency to everything. I'm converting this over from ModernWPF (removed everything). My window backdrop type is set to Mica. I'm assuming it might be an |
@nabeelio maybe something else is changing background settings through winapi after you swap themes - wpfui sets your window background to black/white when you apply any theme, so the window should never become transparent. |
Yeah, maybe. It's very strange. I'll continue debugging, but good to know your fix works as intended! Thank you |
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: #927
What is the new behavior?
Other information
checked on windows 11 22631 build and on windows 10 19045 build (only default light/dark themes with simple demo app)