Fix issue with Werkzeug and weird query string urldecoding #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Doh! I have a couple py3 issues, hang on... |
Werkzeug's request object has a url method that returns a URL with a partially-decoded querystring, causing some methods to fail in weird ways with a message about urlencoding. This patch fixes the problem for me. I have also added a couple tests for the method in the utils model that extracts the params from the request object since it was untested. The second test is the regresssion test that reproduces the bug. I have also removed a test that I think is incorrect. See my comments on the commit here: lepture@7102484
|
OK that should fix it. Needed an explicit byte decode on querystring, werkzeug gives it to you as bytes but gives you the url root as a string for some reason. |
|
merged in 92cf9eb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Werkzeug's request object has a url method that returns a URL with a
partially-decoded querystring, causing some methods to fail in weird ways with
a message about urlencoding. This patch fixes the problem for me.
I have also added a couple tests for the method in the utils model that
extracts the params from the request object since it was untested. The second
test is the regresssion test that reproduces the bug.
I have also removed a test that I think is incorrect. See my comments on the
commit here:
7102484