Updated error handling for Dropbox example #150
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to https://www.dropbox.com/developers/core/docs#oa2-authorize there is no `error_reason` but rather an `error` code (per Section 4.1.2.1 of the OAuth 2.0 spec)
|
Ehh, now see that there are other examples also using So please check which approach is correct; I'll need to admit that I don't yet know how to test raising an error that would show which implementation is correct. |
|
@mdxs These examples are based on facebook. I just copied the code from facebook and made a little modification. |
|
thx and merged in 6479a79 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://www.dropbox.com/developers/core/docs#oa2-authorize there is no
error_reasonbut rather anerrorcode (per Section 4.1.2.1 of the OAuth 2.0 spec)