Support for generating refresh tokens #152
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to 5d0fc1182f6d9826764cc43ade99bc5e5a81c711 in oauthlib, there are now separate generators for access tokens and refresh tokens. Adding a hook to also specify refresh token generator. Test cases are added.
There was a problem hiding this comment.
callable?
I think isinstance is better.
There was a problem hiding this comment.
Well, callable is "undeprecated" as of http://bugs.python.org/issue10518 so I guess callable() would be the way to do it?
|
Well, it's up to you to decide :) I think callable() still is the way to go - see http://stackoverflow.com/questions/16388059/using-callablex-vs-hasattrx-call But please let me know your decision. |
|
this would be nice |
|
ping :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to 5d0fc1182f6d9826764cc43ade99bc5e5a81c711 in oauthlib,
there are now separate generators for access tokens and refresh
tokens.
Adding a hook to also specify refresh token generator.
Test cases are added.