Skip to content

Conversation

Ryan-K
Copy link
Contributor

@Ryan-K Ryan-K commented Nov 2, 2013

The Nonce that was being passed to the noncesetter was always None due to the check for the nonce reusing a variable name.

lepture added a commit that referenced this pull request Nov 2, 2013
nonce parameter was getting clobbered by a local variable name
@lepture lepture merged commit 0b5a20a into lepture:master Nov 2, 2013
@Ryan-K
Copy link
Contributor Author

Ryan-K commented Nov 8, 2013

@lepture: Thanks for merging this... It looks like you have updated the docs for a 0.4.0 release a few days ago.

Are you planning on doing that soon? If not, I'll just update our pip requirements to pull from my repo.

Thanks again!

@lepture
Copy link
Owner

lepture commented Nov 8, 2013

@Ryan-K It may be released soon, but I am not sure. It will happen when I've done the contrib/oauth1.py part.

Are you interested in this part? After all, this will help you to build an oauth1 provider with less effort.

@Ryan-K
Copy link
Contributor Author

Ryan-K commented Nov 8, 2013

@lepture That would likely be useful to people just starting out or that don't want to dive into the internals. I've extended OAuth1Provider since it is really geared toward 3-legged OAuth and expects a resource_owner via an access_token. Some of our users won't be using access_tokens as they aren't acting as known users within our application. I may be able to clean that up and add contribute that back if that sounds useful.

I'll likely update our requirements to temporarily pull from my repo until there's a new release. I was just thinking that since the changelog was updated that the tag was overlooked.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants