Skip to content

Conversation

flippmoke
Copy link

This is primarily an update to change the way that the grant and token getters and setters work. Rather then utilizing the underlying Requests class from oauthlib, the parameters required are passed individually. This makes it more clear what should be saved directly in the setters.

@flippmoke
Copy link
Author

Just noticed an issue where I screwed up the merge. Going to correct the issue then resubmit.

@lepture
Copy link
Owner

lepture commented Jun 11, 2013

Why do you want to change usergetter to usernamegetter?

@lepture
Copy link
Owner

lepture commented Jun 11, 2013

@flippmoke
Copy link
Author

I wanted to change the usergetter to usernamegetter because it was a better way of describing the password credentials only request, which is essentially looking for a username and password. If you can think of a better name, I am open to changing it.

The usergetter I added should be used to pull the information on the currently logged in user. This is useful for creating a user object when using the authorization handler. The use of the usergetter name here makes the most sense to me, and is why I changed the previous usergettter to usernamegetter

@lepture
Copy link
Owner

lepture commented Jun 17, 2013

@flippmoke I don't like the idea. Thanks anyway, version 0.2.0 is nearly out. #12

@lepture lepture closed this Jun 17, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants