Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A bit improvement. #11

Merged
merged 3 commits into from
Jan 26, 2015
Merged

A bit improvement. #11

merged 3 commits into from
Jan 26, 2015

Conversation

tonyseek
Copy link
Collaborator

Changes

  • Capture exceptions explicitly instead of except: all.
  • Use list comprehension instead of lambda + map.

@lepture @VeryCB Please review. Thanks.

@VeryCB
Copy link
Collaborator

VeryCB commented Jan 26, 2015

@tonyseek UT is failed...seems a SyntaxError will be raised if the request body is invalid.

@tonyseek
Copy link
Collaborator Author

@VeryCB The lxml is using a built-in exception here. TAT

@VeryCB
Copy link
Collaborator

VeryCB commented Jan 26, 2015

lgtm

@lepture
Copy link
Owner

lepture commented Jan 26, 2015

LGTM. merge

lepture added a commit that referenced this pull request Jan 26, 2015
@lepture
Merge pull request #11 from tonyseek/refactoring
12112af 
A bit improvement.
@lepture lepture merged commit 12112af into lepture:master Jan 26, 2015
@tonyseek tonyseek deleted the refactoring branch January 26, 2015 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tonyseek @VeryCB @lepture