Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does pylibmc support Python3.3? #146

Closed
ohmeow opened this issue Apr 25, 2014 · 34 comments
Closed

Does pylibmc support Python3.3? #146

ohmeow opened this issue Apr 25, 2014 · 34 comments

Comments

@ohmeow
Copy link

ohmeow commented Apr 25, 2014

Having issues installing it on a Ubuntu server within a Python 3.3.2 project ... so just asking for information. Thansk

@lericson
Copy link
Owner

Yes, but not in any release yet, I'm afraid! Check out the py3k branch, there's an almost release-ready port.

  • Ludvig (phone)

On 25 apr 2014, at 19:31, Wayde Gilliam notifications@github.com wrote:

Having issues installing it on a Ubuntu server within a Python 3.3.2 project ... so just asking for information. Thansk


Reply to this email directly or view it on GitHub.

@ohmeow
Copy link
Author

ohmeow commented Apr 25, 2014

Thanks for letting me/us know Ludvig. I'm fairly new to working on my own VPS, so I'm wondering if there are any instructions for building from the py3k branch so as to get things operational on my Ubuntu 13.10 server?

@lericson
Copy link
Owner

lericson commented May 5, 2014

Quite possibly you would need a lot of the -dev stuff in Ubuntu, not sure myself as I don't use that particular distribution. Perhaps look into that, then get libmemcached installed, and finally the pylibmc py3k branch. Hope it works out!

@lericson
Copy link
Owner

lericson commented May 5, 2014

Also, you will need the Python development headers.

@eskhool
Copy link

eskhool commented May 27, 2014

Ludvig, based on your own availability can you give an approximate time frame for the anticipated releasing the py3k version ...1/3/6 month etc...so we can plan around that? Already working as a core team member on a couple of other OS projects so don't have the bandwidth to jump in on pylibmc but it works great 👍

koobs added a commit to freebsd/freebsd-ports that referenced this issue Jun 30, 2014
- Take maintainership
- Enable AUTOPLIST
- Limit to Python 2.x [1]
- Adjust COMMENT
- Update LICENSE (BSD3CLAUSE)
- Re-order USE{_*} entries

[1] lericson/pylibmc#146
@lericson
Copy link
Owner

lericson commented Jul 4, 2014

Good question, @eskhool -- it's hard to say since there is no release schedule. I think the py3k branch is becoming feature-complete; what remains now is to test it and see that it works as it should. I would like to do this myself, but sadly I don't come into contact with Python 3.x too much :/

@eskhool
Copy link

eskhool commented Jul 4, 2014

@lericson ...Thanks for the update..I will be migrating a major project that relies on pylibmc with Django so it will see some degree of testing ...how about a label or convention for py3 issues to seperate them out

@lericson
Copy link
Owner

lericson commented Jul 4, 2014

Sure, slap 'em on.

@hfalcic
Copy link
Contributor

hfalcic commented Jul 5, 2014

@eskhool For what it's worth, I've been using my pylibmc fork in production for few months as part of a Django (1.6) project. I haven't experienced any problems whatsoever.

@jvc26
Copy link

jvc26 commented Jul 6, 2014

WRT the 3.x merge, is there a PyPI release coming to include py3 support?

@lericson
Copy link
Owner

lericson commented Jul 8, 2014

I would be happy to, but until I or somebody else gets the time to really test these changes I'm not confident enough in the product to release it.

@koobs
Copy link

koobs commented Jul 8, 2014

@lericson Will running the test suite on Python 3.3 & 3.4 suffice?

@lericson
Copy link
Owner

lericson commented Jul 8, 2014

It's a start!

We need to test the cartesian product of py{2.6,2.7,3.4,3.5} and libmemcached-{0.44,0.55,1.0.x}

  • Ludvig (phone)

On 8 jul 2014, at 17:59, koobs notifications@github.com wrote:

@lericson Will running the test suite on Python 3.3 & 3.4 suffice?


Reply to this email directly or view it on GitHub.

@lericson
Copy link
Owner

lericson commented Aug 8, 2014

Hey guys, I ran the test suite in Python 3.x during EuroPython but was unable to get the tests to pass. Any others with the same issue? Did you find a solution?

@jvc26
Copy link

jvc26 commented Aug 22, 2014

Would an addition to the travis-ci file (along the lines of http://docs.travis-ci.com/user/build-configuration/#The-Build-Matrix) enable a matrix build for the combinations?

@lericson
Copy link
Owner

It is certainly possible, but you'd have to make a builder script for libmemcached first. Travis CI bundles it for us, as it currently stands.

@p-lewis
Copy link

p-lewis commented Sep 11, 2014

Hi, I made a travis-ci 2 x 2 matrix with Python 2.7, 3.4 and libmemcached 0.44, 1.0.8. I made a libmemcached PPA for the 1.0.8 environment.

Results: https://travis-ci.org/p-lewis/pylibmc
My travis-ci yaml: https://github.com/p-lewis/pylibmc/blob/py3k/.travis.yml

Looks like python 2 is failing tests, and python 3 is not building.

Happy to continue working on this, but I'd like to know what I should do next. Submit a PR as is? Try and fix build errors? Thanks.

@hfalcic
Copy link
Contributor

hfalcic commented Sep 11, 2014

Your py3k branch is way behind -- you should test off of master. The failures you're seeing were fixed quite a while ago (the Python 3.4 build failure at the end of May, for instance).

@p-lewis
Copy link

p-lewis commented Sep 11, 2014

@hfalcic thanks, I didn't realize the py3k changes were in master.

I've updated and run against master, and the 2x2 matrix is passing.
https://travis-ci.org/p-lewis/pylibmc

I can build out the rest of the matrix shortly.

What version did you want for libmemcached 0.5x? I didn't see an 0.55, I see a 0.53.

https://launchpad.net/libmemcached/+download?memo=10&start=10

@lericson
Copy link
Owner

That's amazing, @p-lewis! Excellent work. All that stands in the way of a proper release now the problem of get_multi, #158.

@lericson
Copy link
Owner

And please do PR, I would think this to be issue hijacking ;)

@hfalcic
Copy link
Contributor

hfalcic commented Sep 13, 2014

The py3k branch has served its purpose, so I propose deleting it.

@lericson
Copy link
Owner

I agree, will do ASAP!

  • Ludvig (phone)

On 13 sep 2014, at 18:25, Harvey Falcic notifications@github.com wrote:

The py3k branch has served its purpose, so I propose deleting it.


Reply to this email directly or view it on GitHub.

@msabramo
Copy link
Contributor

So Python 3 support is in master and issue mentioned above, #158 is closed.

So is it time to do a release with Python 3 support?

Cc: @sontek @aconrad

@sontek
Copy link

sontek commented Oct 24, 2014

I'm offering high fives for any Python 3 related release.

@msabramo
Copy link
Contributor

I'll see @sontek's high fives and also throw in huge kudos.

@sontek
Copy link

sontek commented Nov 13, 2014

beauller

@hfalcic
Copy link
Contributor

hfalcic commented Nov 21, 2014

In my opinion merging #167 is the only blocker.

splbio pushed a commit to splbio/freebsd-ports that referenced this issue Nov 24, 2014
- Take maintainership
- Enable AUTOPLIST
- Limit to Python 2.x [1]
- Adjust COMMENT
- Update LICENSE (BSD3CLAUSE)
- Re-order USE{_*} entries

[1] lericson/pylibmc#146


git-svn-id: svn+ssh://svn.freebsd.org/ports/head@359817 35697150-7ecd-e111-bb59-0022644237b5
@reverie
Copy link

reverie commented Nov 30, 2014

@lericson What can people do to help you cut a py3-compatible release?

@lericson
Copy link
Owner

lericson commented Dec 8, 2014

The answer to the original issue is now simply "yes".

Ho ho ho 🎅 Merry christmas, everyone!

@lericson lericson closed this as completed Dec 8, 2014
@reverie
Copy link

reverie commented Dec 8, 2014

Best present ever. Thank you!

@msabramo
Copy link
Contributor

msabramo commented Dec 8, 2014

Christmas came early this year!

✋ 🍰 🍺 😄

@sbancal
Copy link

sbancal commented Dec 8, 2014

Just in time (for my project, but still a bit early for christmas) ... Wow ... so great!!

@koobs
Copy link

koobs commented Dec 9, 2014

!!!! \o/
I'll update the FreeBSD Port today

uqs pushed a commit to freebsd/freebsd-ports that referenced this issue Dec 9, 2014
- Update to 1.4.1
- Allow Python 3 support [1]
- Update COMMENT to match PyPi upstream
- Add TESTS option, TEST_DEPENDS and regression-test target
- Strip shared library
- Patch setup.{py,cfg} to add allow 'test' command to run
- Update pkg-descr to match upstream
- pkg-descr: Update WWW: URL to match PyPi upstream

This update passes QA (test suite) under Python 2.7 and 3.4.

Changes:

  http://sendapatch.se/projects/pylibmc/changelog.html

[1] lericson/pylibmc#146


git-svn-id: svn+ssh://svn.freebsd.org/ports/head@374342 35697150-7ecd-e111-bb59-0022644237b5
koobs added a commit to freebsd/freebsd-ports that referenced this issue Dec 9, 2014
- Update to 1.4.1
- Allow Python 3 support [1]
- Update COMMENT to match PyPi upstream
- Add TESTS option, TEST_DEPENDS and regression-test target
- Strip shared library
- Patch setup.{py,cfg} to add allow 'test' command to run
- Update pkg-descr to match upstream
- pkg-descr: Update WWW: URL to match PyPi upstream

This update passes QA (test suite) under Python 2.7 and 3.4.

Changes:

  http://sendapatch.se/projects/pylibmc/changelog.html

[1] lericson/pylibmc#146
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests