You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Although the first behavior (silently ignoring unclosed blocks) is the only one which concerns me, I noticed the other behavior while investigating and felt it worth mentioning.
It appears both issues could be fixed by adding an error() when .block() returns falsey at parser.js:1282, but this would trample some other error messages in the test suite and it wasn't apparent to me how to avoid that, so I hope you'll forgive the lack of a PR to address the issue.
Thanks for considering!
Kevin
The text was updated successfully, but these errors were encountered:
Currently
Parser
silently ignores a malformed or missing block for a media query. Some examples are:@media
The missing block is also silently ignored when placed at the end of another block. For example:
Although the first behavior (silently ignoring unclosed blocks) is the only one which concerns me, I noticed the other behavior while investigating and felt it worth mentioning.
It appears both issues could be fixed by adding an
error()
when.block()
returns falsey at parser.js:1282, but this would trample some other error messages in the test suite and it wasn't apparent to me how to avoid that, so I hope you'll forgive the lack of a PR to address the issue.Thanks for considering!
Kevin
The text was updated successfully, but these errors were encountered: