Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check location.port for truthiness #1643

Merged
merged 1 commit into from
Nov 15, 2013
Merged

Check location.port for truthiness #1643

merged 1 commit into from
Nov 15, 2013

Commits on Nov 7, 2013

  1. Check location.port for truthiness 

    According to the w3 spec for Window:

http://www.w3.org/TR/Window/#location

`location.port` might be null. This PR checks that it is truthy before checking for the port's length.

One place where location.port is null is within [jsdom](https://github.com/tmpvar/jsdom), so if you run less within Node, within jsdom, it throws an exception in this code.
    @matthewp
    matthewp committed Nov 7, 2013
    Configuration menu
    Copy the full SHA
    de92480 View commit details
    Browse the repository at this point in the history