Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for math expr/ops error messages line/column numbers. #1714

Merged
merged 1 commit into from
Dec 5, 2013
Merged

Fix for math expr/ops error messages line/column numbers. #1714

merged 1 commit into from
Dec 5, 2013

Conversation

seven-phases-max
Copy link
Member

Fixes #1713.

lukeapage added a commit that referenced this pull request Dec 5, 2013
Fix for math expr/ops error messages line/column numbers.
@lukeapage lukeapage merged commit 5f089a2 into less:master Dec 5, 2013
@lukeapage
Copy link
Member

Thanks,

btw @seven-phases-max don't feel dejected about the pull requests I haven't yet merged. My plan is to put the non-breaking changes into a 1.7 release and then the breaking ones into a 2.0-wip release. for 2.0 I also want to seperate the interface to the environment to allow a common interface that rhino/node/browser/.net implement. thats my plan anyway.. we also have the less docs and I'm re-writing recess as if I didn't have enough on my plate...

@Soviut
Copy link

Soviut commented Dec 5, 2013

Delegate! The biggest problem with open source? Ego-driven development. Sometimes you have to give the boring jobs to somebody.

@seven-phases-max seven-phases-max deleted the math-op-error-msg-fix branch December 5, 2013 10:05
@lukeapage
Copy link
Member

@Soviut I'm more than happy to delegate but at the moment that would require more coordination (over what is in each release) and whomever reviews and pulls in the pull requests to be very careful. Also, technically I think myself and @seven-phases-max seem to be the only ones with enough technical knowledge of less to improve it. the only ego thing about it is that I am anxious to be careful over breaking changes. There are 3 or 4 other people who have commit rights to less but I assume from their lack of comments or action that they don't have the time or are leaving it to me.

@SomMeri
Copy link
Member

SomMeri commented Dec 5, 2013

@Soviut I had commits rights last months, but I'm still new to the codebase and had very fragmented time during that time. So, I limited myself to answering issues, writing docs and such.

I do not want to merge other peoples pull requests, because I know too little about code. In fact, I would consider it very good idea for someone else to review my changes once I will do them. Reviewing others code require more project code knowledge then writing your own changes, at least I think.

I plan to code more once it gets better, but will not merge pull requests until I closed at least some issues on my own.

@Synchro
Copy link
Member

Synchro commented Dec 5, 2013

I'm a lurking committer... I'm really not up to speed on LESS internals, and I'm glad you're taking the lead @lukeapage, but I'm happy to deal with colour processing things that have come up. I'd also like to do more on the docs side. I'm in the middle of a big chunk of work at the moment so I've not managed to do much.

@seven-phases-max
Copy link
Member Author

@lukeapage, sure, no problemo at all, with or without The Big Plan™. I can imagine how much time and efforts one has to waste only to cursory look through all those proposals and requests "randomly" thrown in. So I can only admire a patience and constancy of anyone taking that ungrateful and tiresome role of being the last line of defense against pervasive chaos :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Math operation/expression errors don't show correct line/column number.
5 participants