Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1724 highlighted a misunderstanding of how the contrast function works. I'd thought of this at the time I wrote the contrast function, and I'd incorporated the alpha value into the calculation. This is evidently wrong, because we can't know the background colour, so we have no idea whether the alpha will lighten or darken the colour it's comparing. So the alpha term should be removed from the calculation altogether. While this will affect current users, current output is actively wrong so I don't think it's a BC break, just a bug fix.