Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the "done" message displayed at the end of the compilation with Rhino. #2019

Merged
merged 1 commit into from
Jun 6, 2014

Conversation

gdelhumeau
Copy link
Contributor

Hi.

The "done" message, displayed at the end of the compilation, is useless, in my opinion.

Moreover, in the context of a web application that computes the stylesheet when it is necessary (through lesscss-java, for instance), the done message is stored in the log of the application, meanwhile no bug has happened. I personally try to only display bugs and warning in the logs, in order to not pollute them.

That is why I suggest to remove this message.

What do you think?

Thanks,
Guillaume

@lukeapage
Copy link
Member

I agree, nod lessc doesn't output a message.

lukeapage added a commit that referenced this pull request Jun 6, 2014
Remove the "done" message displayed at the end of the compilation with Rhino.
@lukeapage lukeapage merged commit cd63bc5 into less:master Jun 6, 2014
@gdelhumeau gdelhumeau deleted the remove-done-output branch June 10, 2014 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants