Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "or" keyword and allowed arbitrary logical expression in guards. #2763

Merged
merged 5 commits into from
Jan 14, 2016

Conversation

SomMeri
Copy link
Member

@SomMeri SomMeri commented Dec 20, 2015

This should fix #2705 - Small feature tweak - keyword "or"

SomMeri added a commit that referenced this pull request Jan 14, 2016
Added "or" keyword and allowed arbitrary logical expression in guards.
@SomMeri SomMeri merged commit 8c1fcb5 into less:master Jan 14, 2016
@matthew-dean
Copy link
Member

One thing about this PR, since it was referenced in some recent bugs. This PR was supposed to just add the keyword "or", but it actually added a sizeable chunk of code to the parser. What was the reason for that? Can you explain why that was a necessity?

@seven-phases-max
Copy link
Member

seven-phases-max commented May 7, 2016

"arbitrary logical expression in guards." - see added tests.

In short, before this PR it was impossible to write something like when not((a) and (b)).
By now all regression bugs introduced with and after 2.6.x are fixed. The only current critical thing to concern of (if you're going to make a release) is just #2881 (I'm afraid I would not be able to install the latest node soon so I'm pretty useless for that part, sorry).

@matthew-dean
Copy link
Member

Thanks for the explanation. I did end up doing a release, but may have been premature. (See: #2896)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Small feature tweak - keyword "or"
3 participants