fix: Use make-dir instead of mkdirp #3490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@matthew-dean can you prioritise this fix and a new release please? we are getting security warnings in all of our repos that use less.js because of the deprecated/vulnerable mkdirp dependency. |
matthew-dean
added a commit
that referenced
this pull request
May 5, 2020
* fix: Use make-dir instead of mkdirp * Use compatible make-dir version
|
@alansemenov Released! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3487
minimisthas the vulnerability. By removingmkdirp@0.x(which is deprecated anyway) we get rid ofminimist.Note that we already have to use an outdated version of
make-dirsince less supports node 6 (has reached end-of-life a year ago) whilemake-dir@latestonly supports node 8 (which also reached end-of-life since end of last year).