Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shift the type setting in order to work with Webkit, and fix typo for IE #515

Merged
merged 2 commits into from
Dec 24, 2011
Merged

Shift the type setting in order to work with Webkit, and fix typo for IE #515

merged 2 commits into from
Dec 24, 2011

Conversation

imcotton
Copy link
Contributor

No description provided.

@imcotton
Copy link
Contributor Author

If anyone interested, besides this patch, the current less.js won't working in render of inline <style type="text/less"> block, on any version of IE and WebKit.

@cloudhead
Copy link
Member

Can anyone confirm this? I haven't had any problem so far.

@imcotton
Copy link
Contributor Author

I have made two demo pages on jsFiddle, please check it out: this one works, but that one not.

(btw: please ignore those blank <style> tag, it's just hacking around in order to touch <head> tag according to the official documents)

cloudhead pushed a commit that referenced this pull request Dec 24, 2011
Merge pull request #515 from imcotton/patch-1
d99e366 
Shift the type setting in order to work with Webkit, and fix typo for IE
@cloudhead cloudhead merged commit d99e366 into less:master Dec 24, 2011
@cloudhead
Copy link
Member

Thanks!

@imcotton
Copy link
Contributor Author

Great! So I think the #160 is good to be closed as well.

@cloudhead
Copy link
Member

done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@imcotton @cloudhead