Skip to content

Conversation

alex89200
Copy link
Contributor

Would like to add function to get all issue watchers

Documentation page

@lesstif
Copy link
Owner

lesstif commented Dec 26, 2017

Hi @alex89200

thank you for the contributions.

i think the new watcher class is duplicated from reporter class.

so i will remove watcher class and modifying getWatchers method's mapping code.

thanks!

@lesstif lesstif merged commit 552186d into lesstif:master Dec 26, 2017
@alex89200
Copy link
Contributor Author

Hi @lesstif
thank you for accepting my request.

I agree that watcher is a duplicate, but I think it would be more reasonable to replace it with the User class because they are nearly equal (watcher has just a few fields less than the full user)

thank you!

@lesstif
Copy link
Owner

lesstif commented Dec 27, 2017

hi @alex89200

i agree with you, Watcher class is more readable then Reporter class.

So I will be restored watcher class and reporter class extends it.

thanks.!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants