-
Notifications
You must be signed in to change notification settings - Fork 271
fixed duedate phpdoc #271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed duedate phpdoc #271
Conversation
@@ -443,7 +443,7 @@ public function setSecurityId($id) | |||
/** | |||
* set issue's due date. | |||
* | |||
* @param \DateTimeInterface|null $duedate due date string or DateTimeInterface object |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the implementation of this methods also allows to pass in a string.
when passing in a DateTimeInterface it gets formatted into a string.
hmm not sure whether the testerrors are related.. any hints? |
hi @staabm . PHP json mapper will be process to ''\DateTimeInterface|string' is concrete class name, so it's throw class not found exception. mapping annotation syntax are single or double type name with | delimiter, but you are write the three type name. thanks! |
thx for coming back to me.
sorry, I cannot follow.
phpdoc allow any number of types separated by as the implementation of |
ok, you are right, PHPdoc allow any number of types. but this repos depends on PHP jsonmapper third party library then does not allow multiple property types mapping like this (\DateTimeInterface|string|null). |
hmm ok.. so we can't express that the method beeing used can be invoked with a string (even if the implementation handles this case) ? |
No description provided.